DateTime: Remove deprecated props (and fix static analysis action in trunk) #50724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Code Quality
andrewserong
changed the title
andrewserong
requested review from
a team,
ockham,
noisysocks,
apeatling,
ramonjd and
tellthemachines
and removed request for
a team
|
Size Change: -5.96 kB (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
noisysocks
reviewed
May 18, 2023
andrewserong
added
[Tool] Dependency Extraction Webpack Plugin
ramonjd
approved these changes
May 18, 2023
|
Thanks for the reviews! All actions appear to be passing now, so I'll merge this in. |
|
Was the package-lock change intentional? I'm seeing a diff now when running |
Yes, without it the unit tests action was failing. It's the main thing that changes when updating |
|
For full visibility, since it's probably a bit unusual combining these two things in the one PR:
Usually I'd prefer to do these in two separate PRs, but figured it'd be better to prioritise unblocking merging to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix failing build(s) on trunk.
Remove deprecated props in the
DateTimecomponent (__nextRemoveHelpButtonand__nextRemoveResetButton).Also, bump
caniuse-liteversion, using the same approach as in #46093.Why?
The deprecated props had a version number set to
15.8for when they were due to be deprecated. This causes the build ontrunkto fail now that Gutenberg15.8has been released:Previously, the removal time was bumped six months back in #46006. Now that it's been a year since the props were deprecated, let's go ahead and remove them.
How?
__nextRemoveHelpButtonand__nextRemoveResetButtonprops.__nextRemoveHelpButtonor__nextRemoveResetButtonwere set tofalseTo fix
caniuse-liteunit test failures, borrowing from #46093:Ran
npx browserslist@latest --update-dbwhich updatedpackage-lock.jsonwith the new version of caniuse-lite. Also updated a few snapshot tests as needed.Testing Instructions
DateTimecomponent in Storybook and ensure it works correctly. (npm run storybook:dev)Testing Instructions for Keyboard
Screenshots or screencast