Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State: Replace global hover state with local component state #5078

Merged
merged 1 commit into from
Feb 16, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Feb 15, 2018

This pull request seeks to remove block hover state from the global Redux store. It was only ever used locally within the BlockListBlock component, and handling it as local component state avoids excessive dispatching on mouse events and simplifies global state handling.

Testing instructions:

Verify that there are no regressions with hover behavior:

  • Hover and unhover a block
  • Hovering UI shouldn't be visible when multi-selecting
  • Hovering UI should disappear on typing and reappear on mouse move

@aduth aduth added the [Type] Performance Related to performance efforts label Feb 15, 2018
@aduth aduth added this to the 2.2 milestone Feb 15, 2018
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring

@aduth aduth merged commit 90fbf8e into master Feb 16, 2018
@aduth aduth deleted the remove/hovered-state branch February 16, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Performance Related to performance efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants