ToggleGroupControl: Fix focus and selected style to support Windows High Contrast mode #50785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
commented
May 19, 2023
| @@ -80,6 +82,9 @@ export const BackdropView = styled.div` | |||
| transition: transform ${ CONFIG.transitionDurationFast } ease; | |||
| ${ reduceMotion( 'transition' ) } | |||
| z-index: 1; | |||
| // Windows High Contrast mode will show this outline, but not the box-shadow. | |||
| outline: 2px solid transparent; | |||
| outline-offset: -3px; | |||
There was a problem hiding this comment.
At -2px, the space between outlines seemed too narrow:
t-hamano
added
[Type] Bug
|
Flaky tests detected in 9b38391. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5024609294
|
|
This looks great - thanks @t-hamano! The -3px offset seems good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #50782
Similar to #50772
What?
This PR displays the focus outline and selected outline in ToggleGroupControl when Windows is in high contrast mode.
Why?
Windows high contrast mode does not show box-shadow when focused. In addition, which button is selected or not is not visible in high contrast mode because it is represented only by the background color.
How?
I have added a transparent outline as a focus style. I added a similar transparent outline for which button is selected or not, because the background color is not available.
Screenshots or screencast
screencast.mp4