Fix accessibility issues navigation block experiment #50786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 19, 2023
|
Size Change: +1.15 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9441834. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5055745079
|
luisherranz
approved these changes
May 23, 2023
There was a problem hiding this comment.
I've just tested the changes (using WordPress Playground by the way) and all the issues are fixed.
Great work 🙂
SantosGuillamot
requested review from
spacedmonkey,
tellthemachines and
ajitbohra
as code owners
SantosGuillamot
requested review from
jeryj
and removed request for
spacedmonkey,
ajitbohra and
tellthemachines
SantosGuillamot
deleted the
fix/accessibility-issues-navigation-block-experiment
branch
cbravobernal
added
[Block] Navigation
jeryj
reviewed
May 24, 2023
luisherranz
added
the
[Feature] Interactivity API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the accessibility issues reported related to the navigation block experiment using the Interactivity API:
aria-expandedAttribute on load #50752Why?
There are some parts that don't have the same behavior as the current block.
How?
Instead of calling
openMenuwhenever the button is clicked I created atoggleMenuaction, that calls open/close depending the status of the menu.aria-expandedAttribute on load #50752I included the changes made in this pull request to support enumerated attributes that can contain true/false values. Those are mainly the aria attributes and that is the issue we had with
aria-expandedif I am not mistaken.I moved the
focusoutevent to the parent<li>element so we don't close it until we are outside of the whole submenu. For this to work, we need directives priorities because thecontextandeffecthave to run before that. Although it is not implemented yet, I tested it and it seems to solve the problem.I believe we can also move the
handleMenuKeydown, and part of the overlay menu, but I didn't check that. I'll do that once the priorities are ready.Testing Instructions
Follow the testing instructions in the reported issues and ensure they are solved.