Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process template part shortcodes before blocks (#50801) #50806

Merged
merged 1 commit into from
May 20, 2023

Conversation

priethor
Copy link
Contributor

@priethor priethor commented May 20, 2023

Backports #50801 to the 15.8 branch

Usually, PRs are not needed to backport to minor Gutenberg releases, but I'm going the extra mile with this issue for clarity.

* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded

* Revert "Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded"

This reverts commit 00374e0.

* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded
@priethor priethor requested a review from ajitbohra as a code owner May 20, 2023 01:41
@priethor priethor self-assigned this May 20, 2023
@priethor priethor requested review from desrosj and removed request for ajitbohra May 20, 2023 01:41
Copy link
Contributor

@antpb antpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working good in 6.2.1 with core patch applied. Static Templates are rendering shortcode as expected.

@priethor priethor merged commit 7dfb3b0 into release/15.8 May 20, 2023
@priethor priethor deleted the backport/50801-to-gb158 branch May 20, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants