-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: build render.php when webpack watch in progress #50939
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Takshil-Kunadia! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
I can confirm that it resolves the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix. I'll explore in the follow-up whether we can run the computation only once per change detected by webpack in watch mode.
Congratulations on your first merged pull request, @Takshil-Kunadia! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
Co-authored-by: Takshil Kunadia <takshilkunadia@Takshils-MacBook-Air.local>
PR For :- Issue #49790
What?
render
PHP files without a restart #49790 for more details.Why?
How?
Testing Instructions