Reinstate Text control outside of settings in Link Control #50957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
the
[Feature] Link Editing
|
This PR has also allowed me to notice a potential refactor of settings drawer which I will do in a follow up. Need to also fix the tests here. |
|
Size Change: -1.1 kB (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5369255ee6bc4d099738bbe894ebdb1369060105. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5119141123
|
richtabor
approved these changes
May 25, 2023
|
We are looking to migrate the Puppeteer tests to Playwright for |
getdave
force-pushed
the
update/link-control-move-text-control-outside-settings
branch
2 times, most recently
from
dc19124 to
6fc4e9f
Compare
|
@MaggieCabrera Once your test refactor PRs are merged I think it would be good to rebase here and try and get this in as soon as possible. |
|
Currently failing on |
MaggieCabrera
force-pushed
the
update/link-control-move-text-control-outside-settings
branch
from
6fc4e9f to
8697b26
Compare
MaggieCabrera
force-pushed
the
update/link-control-move-text-control-outside-settings
branch
from
5369255 to
3b39e93
Compare
|
I made a fix for the tests because when we introduce the new input, the modal puts the focus on the text input when opened instead of the URL. I wonder if that's the behavior we want. In any case, the fixes for the e2e are merely a bandaid since these tests are incredibly dependent on the UI, and tabbing to get to where you want. I'll be working on migrating these all to playwright and rewriting them so they are more UI agnostic unless the purpose of the test is to focus on keyboard navigation. |
|
@draganescu looking at the comments on the code that handles focus here I'm not so sure if we want the URL to be focused here (it was the text input before we removed it). In any case, maybe that can be handled in a follow-up? The tests pass now, so this can be merged, I'm not sure if the focus issue is worth blocking this one. Happy to hear anyone else's thoughts. |
Yea I think it's fine to merge. The edit view is getting revisited as a whole. |
MaggieCabrera
deleted the
update/link-control-move-text-control-outside-settings
branch
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…#50957) * Reinstate Text control outside of settings * change selector on tests * fix playwright test * fix the waitForFunction function on the tests * fix e2e tests --------- Co-authored-by: MaggieCabrera <maggie.cabrera@automattic.com>
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reinstates
Textinput control outside of the settings drawer area of Link Control.Part of #50891
Closes #50948
Why?
Because the UX requires it.
How?
Move the control outside the drawer and remove drilled props.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast