Use "Save" instead of "Apply" in Link Control #50964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
the
[Feature] Link Editing
|
Size Change: +19 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2d5fdb7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5088708885
|
richtabor
approved these changes
May 25, 2023
getdave
force-pushed
the
update/prefer-save-term-over-apply-in-link-control
branch
from
b603780 to
2d5fdb7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the Link Control component to use the word
Saveinstead ofApplyfor it's submit button.Why?
As per new Design direction in #50890.
How?
Use new word.
Testing Instructions
Saveand notApply.Testing Instructions for Keyboard
Screenshots or screencast