[RNMobile] Update icon for UngroupButton component #50969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
the
Mobile App - i.e. Android or iOS
|
Size Change: +2.47 kB (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 66d88f6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5081081863
|
fluiddot
requested changes
May 26, 2023
packages/block-editor/src/components/ungroup-button/index.native.js
Outdated
Show resolved
Hide resolved
|
Thanks for the review, @fluiddot! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #50520
Related to #17575
What?
This PR updates the ungroup icon that appears on the toolbar at the bottom of the screen.
Why?
This icon was hard-coded SVG. However, an icon representing the same meaning already exists in the
iconspackage, so I thought it made sense to use it.Testing Instructions
I am a Windows user and tried to debug using Android Studio, but I just could not get the emulator to work properly.
The following icon should appear instead:
I apologize for not being able to test this, but I would appreciate it if you could check to see if this change makes sense.