DropdownMenu v2: Render in the default Popover.Slot #51046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
changed the title
SlotFill
ciampo
force-pushed
the
feat/dropdown-v2-slotfill
branch
from
ad7d8a8 to
551f91b
Compare
ciampo
added
[Type] Enhancement
This was referenced May 29, 2023
andrewserong
approved these changes
May 31, 2023
There was a problem hiding this comment.
This is testing nicely for me, and the logic of ensuring the new DropdownMenu is rendered to the same popover slot as the legacy menu sounds good 👍
✅ Double-checked the Radix UI docs that the container passed to the portal is correct
✅ Tests nicely in Storybook with both the root dropdown menu and any sub menus, with the sub menus correctly picking up the portalContainer from context, and each of the dropdown menu levels being rendered as siblings within the popover-slot:
LGTM! ✨
tyxla
approved these changes
May 31, 2023
| <DropdownMenuStyled.Content | ||
| side={ side } | ||
| align={ align } | ||
| sideOffset={ sideOffset } | ||
| alignOffset={ alignOffset } | ||
| loop={ true } | ||
| > | ||
| { children } | ||
| <DropdownMenuPrivateContext.Provider | ||
| value={ { portalContainer } } |
There was a problem hiding this comment.
Any reason why we memoize the context value in #51097 but not here?
There was a problem hiding this comment.
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Add new slotName prop * Add storybook example * Use context to use same slot for submenu portal * Use default popover slot instead of exposing a slotName prop, update Storybook * CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #50459
What?
Tweak the new
DropdownMenu's behavior so that, instead of appending its contents in thedocument.body, it renders by default in thePopover.Slotslot (thus behaving the same way as the legacyDropdownMenucomponent).Why?
This is to integrate the new component better with how the editor expects its popover-based components to function.
How?
useSlothook to get the reference to the actual DOM elementPopover's default slot nameFurther considerations
We purposefully decided not to expose any new prop on
DropdownMenufor now:slotNameprop (thus keeping the integration withSlotFillan implementation detail of the component), or aportalContainerprop (thus making the component more generic and reusable also for consumers that don't necessarily rely onSlotFill)Testing Instructions
Open the Storybook example, and verify that the contents of the dropdown menu (including its submenus) all render inside the
<div class="popover-slot" />element.