Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation about the entites abstraction and the undo/redo stack #51052

Merged
merged 3 commits into from
May 29, 2023
Merged

Add documentation about the entites abstraction and the undo/redo stack #51052

merged 3 commits into from
May 29, 2023

Conversation

youknowriad
Copy link
Contributor

I think it's important that all Gutenberg contributors understand the entities abstraction. The undo/redo stack is more specialized but also important to document properly.

@youknowriad youknowriad added the [Type] Developer Documentation Documentation for developers label May 29, 2023
@youknowriad youknowriad self-assigned this May 29, 2023
@youknowriad youknowriad requested a review from jsnajdr May 29, 2023 13:25
@youknowriad @oandregal
Apply suggestions from code review
d5b76d8 
Co-authored-by: André <583546+oandregal@users.noreply.github.com>
oandregal
oandregal approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@oandregal oandregal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time.

@youknowriad @oandregal
Apply more suggestions from code review
631a5e6 
Co-authored-by: André <583546+oandregal@users.noreply.github.com>
@youknowriad youknowriad enabled auto-merge (squash) May 29, 2023 14:34
@youknowriad youknowriad merged commit c885bb1 into trunk May 29, 2023
@youknowriad youknowriad deleted the document/undo-redo branch May 29, 2023 14:52
@github-actions github-actions bot added this to the Gutenberg 16.0 milestone May 29, 2023
@github-actions
Copy link

Flaky tests detected in 631a5e6.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5112675556
📝 Reported issues:

@mcsf mcsf mentioned this pull request May 30, 2023
Merged
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
@youknowriad @oandregal @sethrubenstein
Add documentation about the entites abstraction and the undo/redo sta…
8c1319b 
…ck (WordPress#51052)

Co-authored-by: André <583546+oandregal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oandregal oandregal oandregal approved these changes

@mcsf mcsf Awaiting requested review from mcsf

@gziolo gziolo Awaiting requested review from gziolo

@ellatrix ellatrix Awaiting requested review from ellatrix

@ntsekouras ntsekouras Awaiting requested review from ntsekouras

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@ndiego ndiego Awaiting requested review from ndiego ndiego is a code owner

@jsnajdr jsnajdr Awaiting requested review from jsnajdr

Assignees

@youknowriad youknowriad

Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowriad @oandregal