Add template actions in site editor navigation sidebar #51054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Feature] Site Editor
ntsekouras
commented
May 29, 2023
packages/edit-site/src/components/template-actions/rename-menu-item.js
Outdated
Show resolved
Hide resolved
|
Size Change: -990 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
ntsekouras
force-pushed
the
add/template-actions-site-editor-navigation-sidebar
branch
from
8ccef0d
to
23392f4
Compare
|
In this commit I'm addressing the snackbar positioning right now by changing it to absolute position. Any feedback is welcome. Also the change is contained in site editor. |
youknowriad
reviewed
May 30, 2023
| @@ -180,12 +180,7 @@ export default function Editor( { isLoading } ) { | |||
| 'is-loading': isLoading, | |||
| } | |||
| ) } | |||
| notices={ | |||
| ( isEditMode || | |||
There was a problem hiding this comment.
I believe there was a recent PR that did that but was reverted due to some side effects. We might want to check whether this change doesn't introduce these side effects back.
There was a problem hiding this comment.
I know about the other PR and I think the issues there were due to some scale changes. This doesn't seem to affect anything for now.
| import RenameMenuItem from './rename-menu-item'; | ||
|
|
||
| export default function Actions( { template } ) { | ||
| export default function TemplateActions( { |
There was a problem hiding this comment.
It is great that you were able to reuse this. Personally I always prefer reusable components that receive "ids" instead of objects like this as it's more reusable and also more performant in general (can add extra selectors but this won't force the parent to re-render if it's only this component that cares about the object)
There was a problem hiding this comment.
I updated to fetch the data in this component. Also used getEntityRecord and reverted the checks for title.rendered existence.
packages/edit-site/src/components/template-actions/rename-menu-item.js
Outdated
Show resolved
Hide resolved
ntsekouras
commented
May 30, 2023
| @@ -144,7 +145,7 @@ export const removeTemplate = | |||
| sprintf( | |||
| /* translators: The template/part's name. */ | |||
| __( '"%s" deleted.' ), | |||
| template.title.rendered | |||
There was a problem hiding this comment.
This is not related to this PR, but I believe we'll land it soon and it's a small change.
youknowriad
approved these changes
May 30, 2023
ntsekouras
deleted the
add/template-actions-site-editor-navigation-sidebar
branch
This was referenced Jun 6, 2023
43 tasks
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Add template actions in site editor navigation sidebar * add snackbars in site editor and change position to `absolute` * temp title fix for template revert * fetch data in TemplateActions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #50379
This PR adds the template and template part actions regarding:
Notes
There is a problem we need to solve regarding the
snackbarnotices. Currently we show them only in edit mode. This is also related to my initial redirection on deletion to the list of templates/template types, as they show them.What this means is the notices handling here is incomplete because the renaming actions and the rest that will be needed(delete page, etc..) are not shown in view mode. So it needs this issue solved, which had an exploration but got reverted.
Testing Instructions in site editor
Actionsdrop down menu and try the actionsActionsdrop down menu and try the actionsScreenshots or screencast
Screen.Recording.2023-05-30.at.12.44.54.PM.mov