Navigation: Fix ListView deprecation notice #51094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
commented
May 30, 2023
| @@ -32,6 +32,7 @@ const BLOCKS_WITH_LINK_UI_SUPPORT = [ | |||
| 'core/navigation-link', | |||
| 'core/navigation-submenu', | |||
| ]; | |||
| const { PrivateListView } = unlock( blockEditorPrivateApis ); | |||
There was a problem hiding this comment.
A minor code quality change.
Mamaduka
commented
May 30, 2023
| ( select ) => { | ||
| const { __unstableGetClientIdsTree } = select( blockEditorStore ); | ||
| return __unstableGetClientIdsTree( clientId ); | ||
| return !! select( blockEditorStore ).getBlockCount( clientId ); |
There was a problem hiding this comment.
The component doesn't need a whole tree for the hasChildren check.
Mamaduka
added
[Type] Code Quality
Mamaduka
requested review from
scruffian,
getdave and
jeryj
and removed request for
tellthemachines
|
Size Change: -13 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 10655de. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5121817369
|
Mamaduka
force-pushed
the
fix/navigation-list-view-deprecation-notice
branch
from
10655de
to
25453c9
Compare
|
Rebase and ready for review 🙇 |
|
Thanks for opening this one @Mamaduka! Code-wise this looks good to me, but it might be worth getting some feedback from @scruffian or @getdave — I remember there were some previous discussions about the trade-offs between passing down |
andrewserong
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
but it might be worth getting some feedback...
On closer inspection, I think this one's safe to land — I was thinking of the navigation editor within the site editor's browse mode, which also throws the deprecation warning.
For this PR, I see that within the ListView's useListViewClientIds, it'll wind up calling __unstableGetClientIdsTree to get blocks as this component used to (here), so functionally there'll be no difference with this one 👍
✅ Tested that Navigation blocks still display their block tree correctly in the sidebar editor, and when switching between blocks
✅ Checked that the empty state works as on trunk
✅ Deprecation warning isn't appearing anymore while editing a Navigation block
LGTM! ✨
|
Sorry I didn't get to this one in time. I think we decided it was ok to remove the property so we're all good. Thanks for thorough testing 🙇 |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Navigation: Fix ListView deprecation notice * Unlock component at the file level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #49417.
PR fixes the deprecation notice for the Navigation block settings list view.
How?
Only pass
rootClientIdas the deprecation message suggest.Testing Instructions
Screenshots or screencast