[Site Editor]: Add delete action for pages in navigation sidebar
#51101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Feature] Site Editor
ntsekouras
commented
May 30, 2023
| ), | ||
| { | ||
| type: 'snackbar', | ||
| id: 'edit-site-page-removed', |
There was a problem hiding this comment.
We could probably add an undo action here.. Maybe in a follow up? 😄
|
Size Change: +376 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
May 31, 2023
packages/edit-site/src/components/page-actions/delete-page-menu-item.js
Outdated
Show resolved
Hide resolved
Mamaduka
reviewed
May 31, 2023
packages/edit-site/src/components/page-actions/delete-page-menu-item.js
Outdated
Show resolved
Hide resolved
ntsekouras
force-pushed
the
add/delete-page-site-editor-navigation-sidebar
branch
from
21e2cdc to
1dc9145
Compare
|
Flaky tests detected in 0322b34. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5131952054
|
This was referenced Jul 10, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…ordPress#51101) * [Site Editor]: Add `delete` action for pages in navigation sidebar * throw errors on delete and address feedback * close confrim dialog onRemove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #50379
This PR adds a
deleteaction for pages in site editor's navigation sidebar with a confirmation dialog.Testing Instructions
pagesScreenshots or screencast
Screen.Recording.2023-05-30.at.6.30.19.PM.mov