Use generic div instead of nav for <SidebarNavigationScreen /> #51111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeryj
added
[Feature] Navigation Screen
[Focus] Accessibility (a11y)
|
Size Change: -4 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Thanks for looking into this. The unlabeled
Removing the unlabeled Note: out of the scope of this PR: the region now contains a mix of navigational and editing tools. I'm not sure this kind of mixed content is ideal in the first place. |
Good point. I guess it still is the main way to navigate this state, even if you can only use the back button to return to the more pure "navigation." I wonder if the navigation should be collapsed in this state to a smaller sidebar like the collapsed view on the wp-admin dashboard. Then you'd have both a pure navigation and these editor states would be a separate pane? Here's a very rough mockup of what I'm trying to describe. 
|
As for this, the entire area is always wrapped in a |
scruffian
force-pushed
the
fix/sidebar-nav-screen-markup
branch
from
fad6eb3 to
32e7350
Compare
|
Flaky tests detected in 32e7350. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5187564929
|
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48652
What?
The
<SidebarNavigationScreen />of the editor used a<nav>element to wrap the content passed to it, but since its creation that content area has expanded to contain non-navigation content.Why?
The entire area is wrapped in a Navigation region, so the
<nav>element is no longer necessary or relevant in a lot of its uses.How?
Switch the
<nav>to a generic<div>.Testing Instructions
<nav>element in the sidebar markupScreenshots or screencast
Before:
After:
Same, but with a
<div>instead of a<nav>