Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusable blocks: Rename to 'Patterns' and add option to also add a non-synced Pattern #51144
Reusable blocks: Rename to 'Patterns' and add option to also add a non-synced Pattern #51144
Changes from all commits
3475777
25c492a
1314226
24db1a3
4d5f40f
1a6d5e9
6f59ffd
185f214
cb60756
6df91d6
eeadcc9
3291eb2
d8da55d
1e9d2d5
1109fff
cf30182
89d71f7
e2a3fa6
0be9f89
00dc146
90443b0
11cfcf0
011ef3b
2f1af91
77d2a28
a70b271
ff58829
68e42d3
a85e7fc
362777e
693a716
8651478
a23bf9d
6fd9b6c
dbd734c
8ea45d4
571511b
af989d0
7326da2
96a053e
278bc62
c679696
a12c0ff
ce26090
f75223c
2d575ee
a197050
764e82a
370ef36
3311e3b
120091d
7ea3f60
6e3ac59
c21b9d0
542272a
e0e8882
e96852c
302f5f9
c04f927
6d7fd7e
ec7056b
f1975c6
c5845c3
1bbe290
ee75c26
88f48f3
d477199
a309562
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this use the meta capability somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The auth callback has been removed in the backport to core as the relevant checks for user permissions for the given post type are already done, I assume this includes the relevant postmeta permissions - have copied this question over to that port to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This filtering could probably do with some optimization, as
unsyncedPatterns
seems to contain the inserter data for every block type, which then gets filtered down. There's probably a more direct way to do this that doesn't involved getting other non-pattern block types first.Seems like a good task for a follow-up though.