Latest posts: make more link consistent between frontend and editor #51190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsistent ensuring that the ellipsis and "Read more" appear in the editor and frontend, and that they are also translatable.
ramonjd
added
[Type] Bug
|
Size Change: +47 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
ramonjd
commented
Jun 8, 2023
| </a> | ||
| { createInterpolateElement( | ||
| /* translators: excerpt truncation character, default … */ | ||
| __( ' … <a>Read more</a>' ), |
There was a problem hiding this comment.
I added this for i18n. Locales should be able to determine where the ellipsis is, if at all.
It's not the subject of the bug report however and can be rolled back, and the backend changed to match.
apeatling
approved these changes
Jun 8, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…nsistent ensuring that the ellipsis and "Read more" appear in the editor and frontend, and that they are also translatable. (WordPress#51190)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50492
What?
This commit makes rendering Read more on latest post excerpts more consistent ensuring that the ellipsis and "Read more" appear in the editor and frontend, and that they are also translatable.
Why?
With any block theme active, the Latest Posts block displays an unlinked
[...]. In the editor, however, a "Read More" link is rendered.How?
On the frontend, via the excerpt_more hook.
If the block's attributes indicate that excerpts are activated it will render
"… Read more", with the ellipses contained within the translate function.Testing Instructions
Editor
Frontend