Social Icons: Manually set Snapchat label color. #51237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47392
What?
This PR manually sets the color of the Snapchat icon label when no custom icon color or background color is set.
Why?
Unlike all other icons, the Snapchat icon includes both
stroke
andcolor
values because the logo is white on a light yellow background, and the icon needs a black border to show up. Unfortunately, when icon labels are enabled, the font color is white sincecolor
is set to#ffffff
. This makes it impossible to read the Snapchat label.How?
This PR manually sets the color value of the label to black when no custom icon or background color is selected. This approach ensures backward compatibility with minimal modification to the way the block is built. Ideally, we should not have an icon with two colors, but there is no getting around this for the Snapchat logo. Therefore, this one-off solution seems the best path forward.
Testing Instructions
Screenshots or screencast