-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Lightbox: Add a reset button. #51239
Conversation
Size Change: +1.69 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
Flaky tests detected in 7a97ee1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5187104685
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it and it seems to work as expected 🙂 Thanks for the pull request!
I don't love the extra <div>
to prevent the margin bottom, but I cannot think of another way of doing it right now. Anyway, I believe it should be enough for this initial version. We can always change it in the future.
* Add a reset button, e2e tests still pending * Add e2e tests to reset button
What?
Add a
reset
button to the behaviors that removes the attribute from the block code. The behavior applied in this case would be the default one set in thetheme.json
file.Why?
Right now, if the user chooses a behavior, it will stay in the block markup forever, being true or false. This way the user can remove it and the default will be applied.
How?
Adding a reset a button.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Recording.2023-06-05.at.18.07.29.mov
The e2e tests will come in a new PR if this one gets merged before I finish them.: Added