Allow setting block editing mode with specific clientId when no context available #51271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
Size Change: +8 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in eb61716. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5189621289
|
|
I'd prefer that callers that need to specify an explicit |
|
We can close this as the associated actions serve the same purpose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allows consumers of
useBlockEditingModeto pass a specific clientId for situations whereBlockListBlockContextis not available.Co-authored-by: Ben Dwyer 275961+scruffian@users.noreply.github.com
Why?
In #39286 we realised that in certain situations you will need to set the mode when you are outside a block list context. This change enables that whilst preserving the utility of the hook in "get" usage.
Here is the specific code.
How?
Adds an optional
clientIdargument which will take precedence over the value from context if provided.Testing Instructions
The same change is in #39286 so test there following the testing instructions and clicking through into focus mode for a Navigation and checking that the "edit" controls are disabled for the Navigation block.
Testing Instructions for Keyboard
Screenshots or screencast