ListView: Expand/Collapse subtree on double click on a List View item #51327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torounit
added
the
[Feature] List View
|
Size Change: +10 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9028be0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5209858882
|
ndiego
reviewed
Jun 8, 2023
There was a problem hiding this comment.
This works great!
In some applications like Figma, double-clicking allows you to rename what is being clicked on. There has been some conversation around adding such functionality. I would want to make sure that merging this PR does not negatively impact that work should it be included in the future.
@getdave, what are your thoughts here?
I wasn't aware of that conversation, and the "naming" features is important to have as well. So, how to accommodate "Expand/Collapse" and "Rename" together? Some options: A priority to expand collapse
B priority to rename
In MacOS |
|
I would expect that double click would be to rename. Expand the entire tree feels like a power user level feature and so it would be ok to have this behind a modifier key requirement. |
I agree since this is how most design applications work: Figma, Sketch, etc. |
It makes sense, I agree. In Windows Anyone has opinion on the keybinding ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
#51253
Why?
Double-clicking to expand seems like a natural behavior. For example, storybooks, Windows Explorer etc.
How?
Add onDoubleClick event handler to
ListViewBlockSelectButton.Testing Instructions
Screenshots or screencast
2023-06-08.18.53.15.mov