Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug in paragraph affecting content writing when block is left/right aligned. #5135

Merged
merged 1 commit into from
Feb 19, 2018

Conversation

jorgefilipecosta
Copy link
Member

Classes alignright and alignleft were being passed to paragraph RichText, these classes contain CSS that makes the cursor invisible when the paragraph is empty making content writing impossible.

Before

Add a post with an empty paragraph, use Block Alignment setting in inspector controls and choose left or right alignments. See it is impossible to write any content in the paragraph when it is left/right aligned and the cursor is never visible.

How Has This Been Tested?

Verify the behavior described above is fixed and paragraph works as expected.

…s left/right aligned.

Classes alignright and alignleft were being passed to paragraph RichText, these classes contain CSS that make the cursor invisible when the paragraph is empty making content writing impossible.
@jorgefilipecosta jorgefilipecosta added the [Type] Bug An existing feature does not function as intended label Feb 19, 2018
@jorgefilipecosta jorgefilipecosta self-assigned this Feb 19, 2018
@aduth
Copy link
Member

aduth commented Feb 19, 2018

Looks like this might have been introduced originally to add support for wide and full alignment to paragraphs? Doesn't appear to currently be possible, but there's still some lingering references to wide and full in the paragraph block's getEditWrapperProps. I expect these will go away with related refactoring toward align supports (#4069, #5099).

@aduth
Copy link
Member

aduth commented Feb 19, 2018

Wait.. the wide/full alignment does still exist, but only in the sidebar inspector?

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'm now less hopelessly confused about what's going on between the text alignment and block alignment, and can confirm this works as expected 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants