Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Improve string cast render test #5151

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Conversation

aduth
Copy link
Member

@aduth aduth commented Feb 19, 2018

Raised at: #4879 (comment) (props @johnbillion)

This pull request seeks to improve dynamic block rendering tests which verify the string output of a render call. While the behavior itself is working as expected, the tests will wrongly pass even if the string cast was not implemented.

Testing instructions:

Ensure unit tests pass:

npm run test-unit-php

Extra credit: Ensure unit tests fail when removing (string) cast:

return (string) call_user_func( $this->render_callback, $attributes );

@aduth aduth added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Feb 19, 2018
@gziolo gziolo merged commit 30db8f5 into master Feb 20, 2018
@gziolo gziolo deleted the fix/ensure-string-callback branch February 20, 2018 08:12
@gziolo
Copy link
Member

gziolo commented Feb 20, 2018

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants