Get Navigation overlay icons from block editor settings #51527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todo
Pinging @ryanwelcher here who has done a lot of experimenting with the editor and might have some insight on how we might achieve these things. Also @ajlende who has worked a lot with SVG in his Duotone work and might have ideas. |
|
Size Change: +18 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
I wonder whether we need an API to register icons for the editor. Something like register_editor_icon(
name: 'myicon',
label: 'My Icon',
svg: // SVG markup here
);Then we can sanitize the On the block render PHP side we can simply access the icons when we need them and render them with On the JS side we could access the registered icons via an API and render them with Once done we could simply have an editor setting for |
|
Let's wait on the outcome of #53510. If that gets implemented we can implement the solution here. |
|
We can come back to this if/when an Icon API becomes available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Experiment relating to #37930
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast