Combine Site Editor list view tests into a single file #51635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Task
Mamaduka
commented
Jun 19, 2023
Comment on lines
+27
to
+29
| await expect( | ||
| page.locator( 'role=region[name="List View"i]' ) | ||
| ).toBeHidden(); |
There was a problem hiding this comment.
I removed inline comments here; they were remnants of copy/pasta referring to a different element, and the assertion should be self-explanatory enough.
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #51598 (comment).
PR moves List View tests from
block-list-panel-preference.spec.jsinto a newlist-view.spec.jsfile.Why?
These are general List View tests for the site editor, there's no need to keep them in separate files.
Testing Instructions