Fix template display in page details with a custom template #51638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
commented
Jun 19, 2023
packages/edit-site/src/components/sidebar-navigation-screen-page/page-details.js
Show resolved
Hide resolved
|
Size Change: +72 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Jun 19, 2023
Mamaduka
reviewed
Jun 19, 2023
packages/edit-site/src/components/sidebar-navigation-screen-page/page-details.js
Outdated
Show resolved
Hide resolved
Mamaduka
reviewed
Jun 19, 2023
packages/edit-site/src/components/sidebar-navigation-screen-page/page-details.js
Outdated
Show resolved
Hide resolved
ramonjd
reviewed
Jun 19, 2023
packages/edit-site/src/components/sidebar-navigation-screen-page/page-details.js
Outdated
Show resolved
Hide resolved
|
Flaky tests detected in a9e6814. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5310431518
|
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…s#51638) * Fix template display in page details with a custom template * address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the template display in page details with a custom template. Currently if a page has a custom template assigned, its title is not shown in page details panel in site editor. This was because we were searching the default templates only and not all the available ones.
This was mentioned in a different PR by @jameskoster here.
Testing Instructions
pages->some page) and observe that now thetemplate rowis displayed in the page details panel.Screenshots or screencast