Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav block: link text color inheritance fixes and tests #51710

Merged
merged 66 commits into from
Jul 13, 2023
Merged

Commits on Jul 6, 2023

  1. Configuration menu
    Copy the full SHA
    d7587f4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7d1c89d View commit details
    Browse the repository at this point in the history
  3. change setup for tests

    MaggieCabrera committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    4fcc62c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    830a356 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    489f2a4 View commit details
    Browse the repository at this point in the history
  6. finished second test

    MaggieCabrera committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    e419f4f View commit details
    Browse the repository at this point in the history
  7. finished third test

    MaggieCabrera committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    798a886 View commit details
    Browse the repository at this point in the history
  8. started the last test

    MaggieCabrera committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    1f5e5f2 View commit details
    Browse the repository at this point in the history
  9. spacing on comments

    MaggieCabrera committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    1b65241 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c5c6778 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    1c772ab View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    307123f View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    186338a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    1f1fd9e View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    ce5a726 View commit details
    Browse the repository at this point in the history
  16. undo unwanted change

    MaggieCabrera committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    53c8461 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    d737271 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    eb194a1 View commit details
    Browse the repository at this point in the history
  19. fix wrong color syntax

    MaggieCabrera committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    5f50ed5 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    eec98d1 View commit details
    Browse the repository at this point in the history
  21. Add test coverage for selecting group text color that should be inher…

    …ited by all links
    
    This test is currently failing. TDD.
    jeryj committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    77d3df0 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Fix incorrect selector structure.

    The &:where(.wp-block-navigation-item a) rule would never apply, as .wp-block-navigation__responsive-container would never also have a .wp-block-navigation-item class on it. Adding the space allows it to apply the inherit rule to the a tag.
    jeryj committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    7d90814 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a436cd3 View commit details
    Browse the repository at this point in the history
  3. Big refactor of navigation color tests

    * Changed link names from non-descriptive firstLink, secondLink, and thirdLink to clearer names: customLink, submenuLink, and pageLink.
    * Combined some repeated operations such as openEditorOverlay, openFrontendOverlay, and resetGlobalStyles
    * Added ColorControl for keeping track of all the link selectors
    jeryj committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    ce82292 View commit details
    Browse the repository at this point in the history
  4. Revert link color settings changing the navigation link colors

    The trunk behavior is to have text color global styles change the navigation color styles, while the global link color styles do not change the navigation colors. Also updated the tests to not have any of those color changes impact the submenus.
    jeryj committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    4541b41 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Large refactor of navigation color tests

    It was getting difficult to work within several very long tests with a lot of shared code, so I refactored into shared pieces that would make writing the tests easier while keeping debugging easy as well.
    
    Also, one large change was to remove the reliance on global styles since resetting the global styles after a failed test was proving very difficult, and we don't need to use global styles since we can rely on creating a group instead. By wrapping a group on the navigation block we can test the same thing while not needing to deal with global styles.
    jeryj committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    65ea6ca View commit details
    Browse the repository at this point in the history
  2. Add test for navigation background colors

    Also added closing the sidebar in the tests so we don't accidentally grab the links from the sidebar when the navigation block has the sidebar menu open with the same link text.
    jeryj committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    0f6473c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    42086c5 View commit details
    Browse the repository at this point in the history
  4. Only set default navigation submenu and overlay text colors if no nav…

    …igation text color is selected
    jeryj committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    1a3c0b3 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Have li navigation items inherit background color so it can be inheri…

    …ted by the submenu background
    jeryj committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    e7c72ed View commit details
    Browse the repository at this point in the history
  2. Change how to test editor mobile overlay colors

    The tests were a little flaky when tryingn to click the button to open the mobile view since the animation from desktop to mobile in the editor took some time, and the test was trying to click the open menu button before it was able to be clicked.
    
    This updates the test to use the navigation settings itself, which doesn't have an animation, so it should be more reliable.
    jeryj committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    8f27fd3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c693611 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Configuration menu
    Copy the full SHA
    db21c63 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ada037c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8786a7c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3131a7d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    680072d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    716d992 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e726585 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e49f423 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ffc6806 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    57fe3b1 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6988f59 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    1bdd9aa View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    05927a0 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    50113d2 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    53c4d8d View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    c5e10fd View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    83d168c View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    6a80a1b View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    6b3710d View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    2115868 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    b1a9724 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    92f289d View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    ca77108 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    299c028 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    3a261f7 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    4c111b9 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    27a1694 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    ff5be80 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    f1e0f3d View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    f10b86a View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    cfb8266 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    2aa309d View commit details
    Browse the repository at this point in the history
  33. update comments

    scruffian committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    6a0cc47 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    1b66e92 View commit details
    Browse the repository at this point in the history