[Mobile] - Move Undo/Redo buttons #51766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Status] In Progress
2 tasks
|
Size Change: +303 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b23d56a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5519198557
|
13 tasks
12 tasks
added 12 commits
June 29, 2023 10:00
…mmatically due to issues with views and appium
derekblank
approved these changes
Jul 5, 2023
added 5 commits
July 6, 2023 11:49
… Android's main host app activity
…eded for Android's main host app activity
dcalhoun
reviewed
Jul 11, 2023
| fireEvent.press( screen.getByLabelText( 'Undo' ) ); | ||
| fireEvent.press( screen.getByLabelText( 'Undo' ) ); | ||
| fireEvent.press( screen.getByLabelText( 'Undo' ) ); | ||
| toggleUndo(); |
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh thanks for taking care of that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This PR updates the current location of the Undo/Redo buttons moving them from the toolbar into the app navigation header.
Why?
It's part of the current project of updating the mobile editor's UX.
How?
First, it removes the current location for the undo/redo buttons within the header toolbar. It now adds subscription callbacks using the React Native Bridge package to communicate with the host apps.
Updates integration undo/redo tests (editor history) by mocking the
subscribeOnUndoPressedandsubscribeOnRedoPressedcallbacks.React Native Bridge
It adds two new listeners:
onUndoPressedwhich will notify when the undo button was pressed from the host app's navigation header.onRedoPressedwhich will notify when the redo button was pressed from the host app's navigation header.As well as two new functions:
toggleUndoButtonwhich will notify the host app if the undo button should be enabled and not dimmed.toggleRedoButtonwhich will notify the host app if the redo button should be enabled and not dimmed.These are small changes but it involves several files for both platforms.
Device Tests Utils
It updates the
toggleHtmlModeutil to use the "More options button" (three dots) in the new header navigation bar for Android and in the already existing one for iOS.Demo app changes (Android)
Demo app changes (iOS)
Testing Instructions
Testing should be done in both the Android an iOS demo apps.
Screenshots or screencast
iPhone Portrait
iPhone Landscape
iPad Portrait
iPad Landscape
Android Portrait
Android Lanscape
Android Tablet Portrait
Android Tablet Lanscape