Font Face: to generate and print font-face styles for theme.json fonts #51770
Commits on Jul 6, 2023
-
The Resolver handles data interaction between the theme.json and WP_Font_Face. It gets the fonts from theme.json and converts into the array structure needed for font-face processing.
-
This new class handles validating font-face properties and generating and printing font-face styles. Only the "generate_and_print()" method is public exposed. All other functionality is hidden as interworkings. Integrates WP_Fonts_Provider_Local into the class, rather than as a separate provider class, as Font Face only supports local font files. By integrating into the WP_Font_Face, it avoids exposing provider registration and eliminates future BC concerns. If in the future support for custom providers is needed, the local provider functionality can be safely removed from WP_Font_Face without BC concerns or impacts.
-
This function works for both block-powered and classic sites. For block-powered sites, it gets the fonts from theme.json via the Font Face Resolver. For classic sites, themes and plugins can programmatically invoke it and pass their fonts to it. The instance of WP_Font_Face is variable cached within this global function instead of providing a separate global function. Why? The entry point to use Font Face is via wp_print_font_faces(). No other methods are public. Therefore, a global wp_font_face() function should not be needed as it would not provide benefits.
-
Relocate iframed editor assets font printing.
Removes wp_print_fonts() from _gutenberg_get_iframed_editor_assets(). Adds a filter callback to into each global functions file. This approach keeps the code centralized with its specific print function. Benefits: * Avoids switching logic in _gutenberg_get_iframed_editor_assets(). * Avoids confusion for backporting to Core.
-
-
1. The action is passing an empty string. Removed the `array` type hint. 2. Fixed the instantiation code. 🤦
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Return an empty array if no fonts are defined. This method should alw…
…ays return an array
-
-
-
-
-
-
-
Remove unused property.
-
-
-
-
-
-
-
Revert "Quick and dirty fix for non-iframed editor. See https://wordp…
-
1. Adds a test case to the fonts directory. 2. Adds a dataset trait for sharing datasets amongst different test classes. This change the maintance burden of redundant datasets by centralizing in a shared trait. 3.Removes the style variation tests as these are no longer relevant to the Font Face. 4. A wee bit of renaming and reformatting.
-
1. Adds test for when no fonts are passed into the function, i.e. meaning it will pull from the resolver. 2. Improves resolver test to validate the full returned array structure. 3. Moves the expected fonts to the dataset trait to share it between these 2 tests. 4. A wee bit of girlscouting.
-
Bail out if no fonts to process.
1. Adds guard clause to WP_Font_Face::generate_and_print(). 2. Adds unhappy test for it. 3. Adds similar unhappy test for wp_print_font_faces().
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.