Experiment: Use modified version of rememo that uses a tree of Maps #51772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Technical Prototype
|
Size Change: -789 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
noisysocks
force-pushed
the
try/rememo-map-tree
branch
from
b12152a to
1600356
Compare
|
Rebasing this as I can't remember what the Performance Tests job said. |
|
Flaky tests detected in 1600356. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7635948839
|
|
|
Nothing mind-blowing. That settles that then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily overrides Gutenberg's
rememodependency with a built local copy of https://github.com/noisysocks/rememo/tree/try/map-tree-instead-of-linked-list. This allows us to quickly run the Performance Tests action.The
try/map-tree-instead-of-linked-listbranch makes it so that the cache inrememouses a tree ofMaps instead of a linked list. Basically we cache the result ofselector( foo, bar, baz )inmap.get( foo ).get( bar ).get( baz ). This makes cache lookups grow in complexity with the number of arguments (constant) rather than the number of cache entries (linear).