Refactor use-tab-nav shift+tab to use existing utils #51817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3.02 kB (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0fcf63e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5355554012
|
scruffian
force-pushed
the
update/simplify-shift-tab
branch
from
19dce85 to
0fcf63e
Compare
|
Rebasing to get the tests to pass. |
|
Thanks for the rebase, @scruffian! Some of the e2e tests failed due to a real bug related to passing undefined to the block utility functions. Hopefully fixed now. |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Check for truthy values before passing to element block checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexstine mentioned in the review on #51548 (review), that we could simplify the code for determining if we were inside a selected block. This PR refactors to use that code. No behaviors should be changed.
How?
Check if the element in the natural tab order of
taborshift+tabis going to a tabbable elementTesting Instructions
Testing Instructions for Keyboard
Test blocks with form elements
Test Column/Group Block Tabbing (should be same as on trunk)
Test to preserve behavior from #39085
Screenshots or screencast
Screen.Recording.2023-06-15.at.11.45.27.AM.mov