Sidebar Navigation: Refactor delete modal with ConfirmDialog component
#51867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
changed the title
ConfirmDialog component
t-hamano
added
[Block] Navigation
|
Size Change: -21 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
t-hamano
changed the title
ConfirmDialog componentConfirmDialog component
jasmussen
approved these changes
Jun 26, 2023
getdave
approved these changes
Jun 26, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #50880
What?
This PR refactors the modal for removing menus from the sidebar navigation menu with a ConfirmDialog component to improve UI consistency.
Why?
If only yes or no is required in the modal, I feel that the
ConfirmDialogcomponent is appropriate. The following are similar modals using theConfirmDialogcomponent.Delete pattern
Unpublish post
Delete page
How?
Simply refactored using existing logic and text. I was not sure which text to use, OK or Delete, but I used the same Delete label as before.
Testing Instructions
Confirm that the navigation deletion works correctly as before.