Lodash: Refactor away from _.kebabCase() in add page modal
#51911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
SaxonF,
ramonjd,
flootr,
chad1008,
ntsekouras and
fabiankaegy
|
Size Change: -13 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
spacedmonkey
approved these changes
Jun 28, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.kebabCase()from the page creation modal.We have a few more usages of
kebabCase()left in the codebase, but we might have to tread carefully, since some of them may have to deal with unicode characters, and I prefer testing those one by one.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're removing the
kebabCase()usage since even if we pass a non-slugfied slug towp_insert_post(), it will slugify it and return it properly slugified to us. That means that there's no good reason to slugify on the client side.Testing Instructions
/wp-admin/site-editor.php?path=%2FpageCustom % page #$, or try with some unicode characters, like Japanese for example and click the button to create the pagecustom-page.