Navigation block: check that the modal is set before using contains
#51962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial version working with basic support for wp-bind * Add wp-context * Add wp-class * Add wp-style * Add wp-text * Add directive processing tests * Add WP_Directive_Processor class tests * Add wp-bind tests * Add wp-context tests * Add wp-class tests * Add wp-style tests * Add wp-text tests * Add evaluate tests * Fix PHP lint * Prevent errors with incorrect JSON objects * Add support for functions in the server
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
…navigation). (#51194) * Add show and text directives * Move directive bind tests * Move the rest of e2e tests (except csn-related) * Add interactive-blocks plugin for e2e tests * Move test plugins one folder up * Add plugin to .wp-env.json * Change directive-bind spec file to use new plugin * Move plugin to e2e-tests package * Move HTML for directive-bind to plugin * Update exposed properties from preact * Refactor directive-bind spec file * Create directive-effect block for e2e testing * Update directive-effect spec file * Remove unnecessary files * Fix e2e tests for bind and effect directives * Refactor fixtures and use them for bind and effect * Remove unnecessary editorScript * Fix e2e test for directive priorities * Remove unnecessary files * Fix negation operator * Refactor store-tag e2e tests * Refactor directive-class e2e tests * Remove extra spaces * Add util for removing all created posts * Add block for context directive * Add block for directive show testing * Remove unintentionally added artifact * Ignore artifacts generated inside /test/e2e * Remove unused html * Add block for directive text testing * Add blocks for tovdom testing * Update directives syntax in e2e tests * Add getLink to InteractivityUtils * Fix php lint errors * Add disable_directives_ssr param * Fix phpcs errors * Fix missing phpcs error and warnings * Remove `wp-interactivity` from `viewScript` --------- Co-authored-by: Luis Herranz <luisherranz@gmail.com>
luisherranz
force-pushed
the
fix/navigation-block-check-modal-exists
branch
from
47b8eb6
to
3f29f8b
Compare
|
Flaky tests detected in 3f29f8b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5398264987
|
luisherranz
requested review from
spacedmonkey,
kevin940726,
Mamaduka,
ntwb,
nerrad,
ajitbohra,
gziolo,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
I believe the forced push, or the rebase, affected the PR. There are many changes that I think are not relevant to this 😄 |
luisherranz
force-pushed
the
fix/navigation-block-check-modal-exists
branch
from
7e1b096
to
207f047
Compare
luisherranz
force-pushed
the
fix/navigation-block-check-modal-exists
branch
from
207f047
to
06d13da
Compare
|
I fixed it. Let's see if tests finally pass. |
|
Tests finally passed, I need an approval 🙂 |
Mamaduka
approved these changes
Jun 30, 2023
|
Thank you, @Mamaduka! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The context property that stores the modal can be
null, so we should check that it's notnullbefore usingcontains.Why?
I saw an error in the console while testing the menu.
How?
Just use the
?optional property access operator.Testing Instructions
Unfortunately, I was not able to find the steps to reproduce it again.