Add private selector support to resolveSelect and suspendSelect #52036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +33 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
draganescu
reviewed
Jun 28, 2023
jsnajdr
force-pushed
the
fix/resolve-private-selectors
branch
from
75d8c79 to
df5bf85
Compare
|
Did this ever come up again? |
|
I think I merged some parts of it as separate, incremental PRs. I'll need to have a closer look at what is the remaining work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for resolvers to private selectors -- until now private selectors were never bound to the specified resolvers.
Also adds support for private selectors to
resolveSelectandsuspendSelect. Until now these function were returning only public selectors. Now they return locked objects that can be unlocked to access also private selectors.This is still a draft, I'll probably merge it as several separate PRs, and would like to do some more refactoring and add some comments. The code that binds selectors and exposes them has become very complex. All the proxies and all.
This is a follow up to discussion started in #51413 (comment).