-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @examples to the @wordpress/rich-text package selectors and hide the actions from documentation. #52089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwelcher
added
[Type] Developer Documentation
Documentation for developers
[Package] Rich text
/packages/rich-text
Developer Experience
Ideas about improving block and theme developer experience
labels
Jun 28, 2023
ryanwelcher
requested review from
ellatrix,
fluiddot,
dcalhoun,
ajitbohra,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
June 28, 2023 18:26
ryanwelcher
changed the title
Feature/add examples to rich text package
Add @examples to the @wordpress/rich-text package selectors and hide the actions from documentation.
Jun 28, 2023
19 tasks
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
ndiego
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Developer Experience
Ideas about improving block and theme developer experience
[Package] Rich text
/packages/rich-text
[Type] Developer Documentation
Documentation for developers
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds
@examples
for the existing selectors and adds@ignore
tag to the actions as developers should not dispatch them directly and instead use the appropriate functions.Part of #4212