Global Styles Revisions API: backport changes from Core

[ramonjd]

What?

Backport changes to the Global styles revisions endpoint from Core to Gutenberg.

Changes include:

• pagination
• request headers X-Wp-Total and X-Wp-Totalpages
• new tests

See: WordPress/wordpress-develop#4606

Testing Instructions

Check that there are no regressions. Check out the test description over at #50089

A quick way to test the endpoint in the site editor, fire up this branch and head over to the site editor.

In your browser's console, switch to the network tab and run the following :

await wp.apiFetch( { url: `/index.php?rest_route=%2Fwp%2Fv2%2Fglobal-styles%2F${ wp.data.select('core').__experimentalGetCurrentGlobalStylesId() }%2Frevisions&_locale=user` } );

Run PHP unit tests:

npm run test:unit:php -- --filter Gutenberg_REST_Global_Styles_Revisions_Controller_Test

For the /global-styles/<id>/revisions endpoint, check that the response headers are set:

[github-actions]

Flaky tests detected in 7c56354.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5408182604
📝 Reported issues:

• [Flaky Test] should convert to a preformatted block #51607 in /test/e2e/specs/editor/various/convert-block-type.spec.js

[tellthemachines]

Thanks for the PR! The changes look good and revisions are still working as expected.

What about the class Gutenberg_REST_Global_Styles_Revisions_Controller added in #49974? Should that be moved to lib/compat/wordpress-6.3/ now that the controller is in core?

[ramonjd]

What about the class Gutenberg_REST_Global_Styles_Revisions_Controller added in #49974? Should that be moved to lib/compat/wordpress-6.3/ now that the controller is in core?

That was done a while back in b6986e0b, unless I'm missing something?

[tellthemachines]

That was done a while back in b6986e0b, unless I'm missing something?

No, that's correct, I should have checked more carefully 😄