Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move block editor settings filter into 6.3 compat folder #52100

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Move block editor settings filter into 6.3 compat folder #52100

merged 1 commit into from
Jun 29, 2023

Conversation

tellthemachines
Copy link
Contributor

What?

Now that post content attributes have been added to the block editor settings in core (WP 6.3), the corresponding Gutenberg filter can be moved to the 6.3 compat folder.

Testing Instructions

  1. With a block theme enabled, edit the Post Content block to give it a custom layout (justify left or right, for example).
  2. Open the Post Editor, which should immediately display the correct Post Content layout.

Testing Instructions for Keyboard

Screenshots or screencast

@tellthemachines tellthemachines added [Package] Edit Post /packages/edit-post Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core labels Jun 29, 2023
@tellthemachines tellthemachines self-assigned this Jun 29, 2023
ramonjd
ramonjd approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tellthemachines tellthemachines merged commit dc1dab9 into trunk Jun 29, 2023
@tellthemachines tellthemachines deleted the update/post-content-in-settings branch June 29, 2023 06:04
@github-actions github-actions bot added this to the Gutenberg 16.2 milestone Jun 29, 2023
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
@tellthemachines @sethrubenstein
Move block editor settings filter into 6.3 compat folder (WordPress#5…
0db98fd 
…2100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonjd ramonjd ramonjd approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@tellthemachines tellthemachines

Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Package] Edit Post /packages/edit-post
Projects
None yet
Milestone
Gutenberg 16.2
Development

Successfully merging this pull request may close these issues.
2 participants
@tellthemachines @ramonjd