List View: Return primitive value for 'hideInserter' in Appender component #52161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
scruffian and
tyxla
and removed request for
ellatrix
Mamaduka
added
[Type] Code Quality
|
Size Change: -11 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 98dbca4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5420800508
|
|
Thanks, @tyxla! Do you think it makes sense to return early in Something like this: export default function isShallowEqual( a, b ) {
if ( a === b ) {
return true;
}
if ( a && b ) {
if ( a.constructor === Object && b.constructor === Object ) {
return isShallowEqualObjects( a, b );
} else if ( Array.isArray( a ) && Array.isArray( b ) ) {
return isShallowEqualArrays( a, b );
}
}
return a === b;
}cc @jsnajdr |
|
I think it's a neat idea, especially given that we're doing it in all code paths (both for arrays and objects). It could help reduce some duplication at no cost. Just note that it's will no longer make much sense to have Feel free to open a PR, I'm happy to review it 👍 |
We'll have to leave checks in other code paths as they're exported and can be used separately. |
Good point, that's correct. In that case, there isn't that much of an improvement if we do it one more time earlier than the condition IMHO. |
|
Thanks for sharing your thoughts, @tyxla! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates the selector to return the
booleanvalue directory.Why?
The "shallow equality" check will skip extra steps for primitive values.
P.S. I was experimenting if we can make a screen reader announcement without
useEffectand decided to push this minor improvement.Testing Instructions
Confirm that the list view Appender is correctly rendered for the Navigation block.
Screenshots or screencast