Perf: Try out post editor perf tests with tinymce disabled #52245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
|
Flaky tests detected in a2f4bf2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5444674586
|
|
First results are as follows: My initial interpretation: even though the I'd have to run some more tests on it to get a better understanding. |
|
Doing some more runs after talking to @WunderBart with the following setup:
Results so far appear to demonstrate 10% faster post editor loading metrics! |
|
It's a bummer that perf tests have a bunch of noise, though. Some runs will show a ~20% improvements, others 10%.... I'd regrettably say this is not a very reliable way to assess performance improvements. |
|
Now that we have a raw idea of the perf improvements, I'm going to be running some manual tests and some debugging to try to repro warnings reported in #50387 (comment). Closing this one and deleting the aforementioned branches for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR explores running the post editor performance tests with TinyMCE disabled.
This PR is a continuation of #50387.
DO NOT MERGE.
Why?
To assess the performance impact through the performance tests.
How?
We're duplicating the post editor perf tests to try it out.
Testing Instructions
Observe the performance test results.
Testing Instructions for Keyboard
None
Screenshots or screencast
None