Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patterns: Update section heading levels #52273

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Patterns: Update section heading levels #52273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions packages/edit-site/src/components/page-patterns/grid-item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import {
DropdownMenu,
MenuGroup,
MenuItem,
__experimentalHeading as Heading,
__experimentalHStack as HStack,
__unstableCompositeItem as CompositeItem,
Tooltip,
Expand Down Expand Up @@ -155,12 +154,7 @@ export default function GridItem( { categoryId, composite, icon, item } ) {
icon={ itemIcon }
/>
) }
<Flex
as={ Heading }
level={ 5 }
gap={ 0 }
justify="left"
>
<Flex as="span" gap={ 0 } justify="left">
{ item.title }
{ item.type === PATTERNS && (
<Tooltip
Expand Down
8 changes: 6 additions & 2 deletions packages/edit-site/src/components/page-patterns/patterns-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ export default function PatternsList( { categoryId, type } ) {
{ ! isResolving && !! syncedPatterns.length && (
<>
<VStack className="edit-site-patterns__section-header">
<Heading level={ 4 }>{ __( 'Synced' ) }</Heading>
<Heading as="h2" level={ 4 }>
{ __( 'Synced' ) }
</Heading>
<Text variant="muted" as="p">
{ __(
'Patterns that are kept in sync across your site'
Expand All @@ -94,7 +96,9 @@ export default function PatternsList( { categoryId, type } ) {
{ ! isResolving && !! unsyncedPatterns.length && (
<>
<VStack className="edit-site-patterns__section-header">
<Heading level={ 4 }>{ __( 'Standard' ) }</Heading>
<Heading as="h2" level={ 4 }>
aaronrobertshaw marked this conversation as resolved.
Show resolved Hide resolved
{ __( 'Standard' ) }
</Heading>
<Text variant="muted" as="p">
{ __(
'Patterns that can be changed freely without affecting your site'
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/page-patterns/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
}

.edit-site-patterns__pattern-title {
color: $gray-600;
color: $gray-200;

.edit-site-patterns__pattern-icon {
border-radius: $grid-unit-05;
Expand Down
Loading