-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promisify action creator return type for WP data dispatch #52530
Merged
+55
−20
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5162962
Promisify action creators in ActionCreatorsOf type
noahtallen 943ff9c
Add singular and plural helper types
noahtallen 3046bf7
Add returntype for promisified action creators
noahtallen a9aad26
Add changelog entry
noahtallen 9566b70
Update plain dispatch to handle string store descriptor
noahtallen 006048e
Update PromisifiedActionCreator to handle thunks
noahtallen e08fd01
Update generated docs
noahtallen de0aeae
Clarify comments
noahtallen 1b9b7ad
Account for async thunks
noahtallen cc4ca6a
Update changelog
noahtallen 8cbdc88
Make comment less redundant
noahtallen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Promisify action creators in ActionCreatorsOf type
commit 5162962a5c1f7f17c4f2f19d2bda051353839a60
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function
doesn't let you add return types and isn't compatible with the arrow syntax, so it needs to be changed so that we can wrap around the type below.