Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footnotes: Attempt to iterate into nested blocks that use useInnerBlocksProps in the save function #52676

Closed
wants to merge 1 commit into from
Closed

Footnotes: Attempt to iterate into nested blocks that use useInnerBlocksProps in the save function #52676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/block-editor/src/components/rich-text/get-rich-text-values.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ function addValuesForElement( element, ...args ) {
case Fragment:
return addValuesForElements( props.children, ...args );
case RawHTML:
return;
// `useInnerBlocksProps.save()` will return a `RawHTML` element,
// so use this as an indicator to recurse into the children.
return addValuesForBlocks( ...args );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you know that this is the correct RawHTML instance for which to process inner blocks?

case InnerBlocks.Content:
return addValuesForBlocks( ...args );
case Content:
Expand Down Expand Up @@ -81,7 +83,7 @@ function addValuesForElements( children, ...args ) {
function addValuesForBlocks( values, blocks ) {
for ( let i = 0; i < blocks.length; i++ ) {
const { name, attributes, innerBlocks } = blocks[ i ];
const saveElement = getSaveElement( name, attributes );
const saveElement = getSaveElement( name, attributes, innerBlocks );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid passing this down as block because they'll be serialised, which is unperformant.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created an alternative PR: #52682

addValuesForElement( saveElement, values, innerBlocks );
}
}
Expand Down