Fix: Navigation block is broken when focus is applied to the ellipsis menu in the block sidebar #52694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… menu in the block sidebar
|
Size Change: +2 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
t-hamano
requested review from
draganescu,
scruffian,
getdave and
tellthemachines
t-hamano
added
[Type] Bug
|
Flaky tests detected in c0adc8e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5577350374
|
|
This seems to be connected to #52635. I can't replicate it consistently, but I think we need to look into the root cause. |
|
Yes, I am consistently able to reproduce this issue.
Perhaps if you have made some changes to the Navigation block, you may not be able to reproduce this issue. if you run |
|
@scruffian is it to do with which endpoint fetches the entity? Maybe the fallback vs the standard posts endpoint? The fallback |
|
@t-hamano those steps don't work for me. I have totally wiped my site and started again. I have seen the issue though, so I'll keep trying to replicate it... |
|
I think this is how we should fix it: #52758 |
|
I have confirmed that the issue has been resolved by #52758 and will close it. |
priethor
added
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #52691
What?
This PR fixes a problem in the sidebar of the navigation block where the block breaks when focus is placed on the topmost ellipsis menu.
ae29b02f8bf98120609e5e8aff50f243.mp4
Why?
The direct cause is that the object is passed to the text of the
ToolTipcomponent. ThecurrentTitlethat this PR is modifying is used in this text.My guess is that when the default navigation embedded in the theme's template is rendered by the site editor, its title will be an object with the rendered property because it is processed server-side.
How?
I have made the
renderedproperty the preferred title.Testing Instructions