[RNMobile] Wrap mobile block toolbar Block Settings Button with ToolbarGroup #52715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekblank
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
|
Flaky tests detected in f2d926c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5583836722
|
geriux
reviewed
Jul 18, 2023
| } } | ||
| </BlockSettingsButton.Slot> | ||
|
|
||
| <ToolbarGroup> |
There was a problem hiding this comment.
Nice that it was just wrapping the element! I was thinking if we should have it in the component instead? To be consistent with the other block controls, what do you think?
There was a problem hiding this comment.
I was thinking if we should have it in the component instead?
Yep, that's even better. I've updated the code. 👍
geriux
approved these changes
Jul 18, 2023
geriux
removed
the
Mobile App - Automation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Wraps the mobile block toolbar Block Settings Button with ToolbarGroup.
Why?
To match consistency with other design elements in the mobile block toolbar. ToolbarGroup provides consistent borders on the left and right of the Block Settings Button.
How?
Updates the code of
block-toolbar/index.native.jsto includeToolbarGroupand wraps theBlockSettingsButton.Slotcomponent.Testing Instructions
Screenshots or screencast