Global Styles: Add link to compare revisions #52829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Enhancement
cbravobernal
requested review from
michalczaplinski,
ramonjd and
SantosGuillamot
|
Size Change: +296 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
69 tasks
13 tasks
|
Things are working well for me and I agree it would be helpful for some folks to have access to the WP revisions UI. I'm just not sure about the button's position/UI. I guess it depends on how prominent we want things. cc @jameskoster for a learned opinion |
|
I can totally understand why this might be useful. Even with a side-by-side visual comparison it may not always be possible to see the changes. For example the document may not contain blocks that were styled between revisions. That said, the post revisions UI feels a bit clunky here. When there are more than a couple of changes in the revision it becomes very difficult to actually figure out what has changed. Would it be a lot of work to bring a simplified version of this UI into the editor, and parse the changes? So that instead of: 
You saw something like this table in a modal: 
(This is a very rough mockup. If it's feasible it'd need some further design exploration to get the details right). |
Thanks for the feedback! It'd be very handy if we could pull this kind of data via an API or something. I'll have a quick poke around to see what's available. |
You have the original styles, settings and behaviors object and the revision styles, settings and behaviors object. I think is possible to compare them and show those changes. This PR was intended as a quick win to have a way to check behaviors, but I can make a POC of that design. |
Oh definitely! 👍🏻 I only wanted to sniff around and see what things like I wonder: with which version would we compare the currently-selected? The previous or the currently-saved? |
I think it compares the currently-saved with the one selected when you click on the revisions list.
Reusing that function would be great! 👍 |
cbravobernal
force-pushed
the
enhancement/preview-revision-behaviors
branch
from
5cf7de0
to
536b417
Compare
|
I've put the PR again to Draft. As now is not ready for merge, I commited with a function that compares revision and current config that we can display in a modal.
|
cbravobernal
force-pushed
the
enhancement/preview-revision-behaviors
branch
from
536b417
to
5999e19
Compare
|
Flaky tests detected in 5999e19. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5693207882
|
|
After spending some time in this issue I found that comparing the styles object in order to get blocks, elements, styles, etc would at least require to work in a comparison engine with 4 or 5 levels deep. It's not trivial, but I think it could be a good addition to the Core, as it would work also to compare different themes I've been checking I will be on parental from next week until October, so I'm afraid I won't be able to keep this PR. But, if we needed an answer, yes, it is feasible, hard though and resource consuming too. @ramonjd I leave up to you the decision on this matter or to the contributors in charge of Global Styles. |
|
Thanks a lot for spending time experimenting here @c4rl0sbr4v0
Yeah, it seems like it could become non-performant for large changesets. I wonder if we could limit things to the top levels, e.g., In general, I'm happy to let these explorations stew a bit, and allow time for design iterations and more discussion. 🙇🏻 |
2 tasks
|
I'm closing this experiment @ramonjd It seems there will be new Global Styles Revisions enhancements, and this PR was created as a quick solution for different lightbox animations, which right now are not in the editor any more. Thanks for all the feedback! |
|
Thanks @c4rl0sbr4v0 I might come back to this to see if we can leverage what you've learned here. I think they'll still be very useful. I appreciate the explorations you've made! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a link to /wp-admin/revisions to compare Global Styles post revisions.
Why?
The current process of checking changes included in each global styles revision is done solely through the Site Editor. Users need to visually inspect the site preview on the left side to identify the modifications. However, since behaviors are only applied on the frontend, it becomes impossible to verify the differences between versions directly in the editor. Additionally, for larger websites, spotting the changes can be challenging.
How?
The quickest solution is to add a link to the existing interface of post revisions. We could in a future implement that view in the site editor canvas.
Testing Instructions
Change styles, settings or behaviors to create revisions.
Go to revisions sidebar, click on one different, use the link.
Testing Instructions for Keyboard
Screenshots or screencast
Link:
Destination:
Video:
https://github.com/WordPress/gutenberg/assets/37012961/72615a37-afa2-413d-9676-0050a29e540b