Add fitted prop to TabPanel
#52845
Closed
Add fitted prop to TabPanel
#52845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: +58 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Could this feature wait a little bit? We are in the process of building a new version of this component that would be more modular in design, so that the consumer can achieve this kind of tab style more easily, perhaps not even requiring a prop. cc @chad1008 |
|
It can totally wait :) |
31 tasks
6 tasks
|
Let's close this PR for now, since — as @mirka explained — we're working on a new version of We can always re-open this PR in the future if needed. |
jameskoster
added
the
Design System
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #42320.
What?
Adds a
fittedprop to theTabPanelcomponent. Whentrue, tabs will grow to fill their container horizontally.Why?
Sometimes this layout is desirable, so it would be good to have a consistent way of achieving it.
An example of something we might do:
This addition would also facilitate the removal of the custom styling that currently implemented in order to achieve this layout in the block inspector:
How?
Add
fittedprop toUnforwardedTabPanel. Whentrue, child.components-tab-panel__tabs-itemelements receive:Testing Instructions
npm run storybook:dev).true.