Template Descriptions: Tidy up all abbreviations of 'example' to be e.g. #52848
Conversation
Instead of e.g, or e.g..,
|
Addresses #52755 |
| @@ -49,7 +49,7 @@ function gutenberg_get_default_block_template_types( $default_template_types ) { | |||
| $default_template_types['singular'] = array( | |||
| 'title' => _x( 'Single Entries', 'Template name', 'gutenberg' ), | |||
| 'description' => __( | |||
| 'Displays any single entry, such as a post or a page. This template will serve as a fallback when a more specific template (e.g., Single Post, Page, or Attachment) cannot be found.', | |||
| 'Displays any single entry, such as a post or a page. This template will serve as a fallback when a more specific template (e.g. Single Post, Page, or Attachment) cannot be found.', | |||
There was a problem hiding this comment.
We'll also have to change the corresponding strings in the E2E tests.
See the failing test below.
There was a problem hiding this comment.
Thanks @ramonjd - is that something I can do within this repo - or is it tooling that is specific elsewhere?
There was a problem hiding this comment.
is that something I can do within this repo
Yes for sure. The files exist in the Gutenberg repo.
If you can do a "find in files" search for the modified strings you should be able to hunt them down.
Here's the one:
I think that's the only one, but it wouldn't hurt to check
|
Changes LGTM. I think we just need to update the strings in the E2E tests as well 👍🏻 |
|
@ramonjd looks like I'm presuming that is ok because it is optional, and not relevant to this PR? |
You presume correct! The issue is that that particular Github action doesn't have permissions to run on PR from forks. I need to fix that 😄 |
mikachan
added
[Type] Copy
|
What?
Making all abbreviations of 'For Example' to be consistent in the template descriptions
Why?
Previously the descriptions were inconsistent (and some were incorrect).
How?
Copy changes to consistently use
e.g.Testing Instructions
Can be tested by opening the Site Editor > Templates and clicking on each template to see the template details.