-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Upgrade Gradle to 8.2.1 and AGP to 8.1.0
#52872
Merged
fluiddot
merged 50 commits into
trunk
from
rnmobile/0.69.4-upgrade-gradle-to-8.2.1-and-agp-to-8.0.2
Jul 28, 2023
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
cc1ca68
Build: Move android related gradle properties to its own group for aztec
ParaskP7 eb29afb
Deps: Extract agp version to settings build gradle for aztec
ParaskP7 22ed356
Deps: Extract publish to s3 version to settings build gradle for aztec
ParaskP7 3c2cd6f
Deps: Add versions groups to root build gradle for aztec
ParaskP7 dd97556
Deps: Extract androidx legacy version to root build gradle for aztec
ParaskP7 2a66c7a
Deps: Extract androidx gridlayout version to root build gradle for aztec
ParaskP7 0767c4e
Deps: Extract androidx cardview version to root build gradle for aztec
ParaskP7 d9af77e
Deps: Extract androidx appcompat version to root build gradle for aztec
ParaskP7 7c2c07b
Deps: Extract androidx recyclerview version to root bld gradle for aztec
ParaskP7 3569054
Deps: Extract junit version to root build gradle for aztec
ParaskP7 62ac0b8
Build: Upgrade gradle to 8.1.1 for aztec (1/2)
ParaskP7 f63df55
Build: Upgrade agp to 8.0.2 for aztec
ParaskP7 57acd33
Build: Move package from android manifest to build files for aztec
ParaskP7 ba72061
Build: Upgrade gradle to 8.1.1 for aztec (2/2)
ParaskP7 c0d9c1a
Build: Migrate dsl properties from lint options to lint for aztec
ParaskP7 c106962
Build: Upgrade gradle to 8.2.1 for aztec
ParaskP7 ab9d379
Build: Move android related gradle prop. to its own group for bridge
ParaskP7 60a411f
Deps: Extract agp version to settings build gradle for bridge
ParaskP7 9ceb140
Deps: Extract publish to s3 version to settings build gradle for bridge
ParaskP7 143c768
Deps: Extract facebook fresco react native related version for bridge
ParaskP7 e60fa86
Deps: Extract google material version to root build gradle for bridge
ParaskP7 fc5ad2a
Deps: Extract wordpress utils version to root build gradle for bridge
ParaskP7 ab4ba07
Deps: Extract junit version to root build gradle for bridge
ParaskP7 61b8972
Build: Upgrade gradle to 8.1.1 for bridge (1/2)
ParaskP7 565f0b8
Build: Upgrade agp to 8.0.2 for bridge
ParaskP7 4592d13
Build: Move package from android manifest to build files for bridge
ParaskP7 41ba3ac
Build: Enable build config build feature for bridge
ParaskP7 f80c182
Build: Upgrade gradle to 8.1.1 for bridge (2/2)
ParaskP7 47210b7
Build: Migrate dsl properties from lint options to lint for bridge
ParaskP7 fb26a88
Build: Upgrade gradle to 8.2.1 for bridge
ParaskP7 1d6ffba
Build: Upgrade gradle to 8.2.1 for editor
fluiddot a3ce586
Build: Upgrade agp to 8.0.2 for editor
fluiddot 7f6f343
Build: Move package from android manifest to build files for editor
fluiddot 9469e37
Build: Enable build config build feature for editor
fluiddot 4794892
Patch `react-native-gradle` package
fluiddot 6eba537
Include correct `react-native-aztec` project in bridge
fluiddot 693c0fe
Use newer version of React Native Gradle plugin
fluiddot bf340a4
Make `else` statement one-line format in editor's `settings.gradle`
fluiddot 66a02f9
Remove aztec project inclusion when publishing bridge binaries
fluiddot f1738ff
Use Java 17 in Android E2E tests
fluiddot 86c5dc2
Update publish-to-s3 Gradle plugin to 0.8.0
fluiddot ced1fc9
Revert removing package from AndroidManifest
fluiddot 67ca6bd
Add inline comment to remind updating package name
fluiddot 0cf7e42
Add `.java-version` file to use Java 17
fluiddot d031dfd
Merge branch 'trunk' into rnmobile/0.69.4-upgrade-gradle-to-8.2.1-and…
fluiddot 1ba4251
Bump Android Gradle Plugin to `8.1.0`
fluiddot 665c586
Remove `react-native-gradle` patch
fluiddot 7fead25
Update `react-native-editor` changelog
fluiddot 6300536
Merge branch 'trunk' into rnmobile/0.69.4-upgrade-gradle-to-8.2.1-and…
fluiddot 0f7ee31
Remove TODO inline comment in `build.gradle`
fluiddot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 2 additions & 2 deletions
4
packages/react-native-bridge/android/react-native-bridge/src/main/AndroidManifest.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/react-native-editor/android/app/src/main/AndroidManifest.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The React Native CLI fetches the
packageattribute from AndroidManifest files, so we can't remove it. Otherwise, we encounter the following error when installing the Pods for the demo project:This can be tested by removing the
packageattribute and running the commandnpx react-native config(this command is used behind the scenes when installing the Pods).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is okay (safe) to keep this package definition here @fluiddot , that is, as long as we make sure to have the same namespace defined on the inner
react-native-bridge/build.gradlelevel, just we already did. 👍PS: We just need to not forget to update one without the other, that is, if we ever need to do something like that anyway (but I doubt that this will be happening anytime soon). 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I think having an inline comment in both
build.gradleandAndroidManifest.xmlfiles reminding this would be helpful to avoid forgetting that both need to be updated. I'll add this 💨 .There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied my above suggestion in 67ca6bd.