Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: backport Core changes for the navigation fallback #52878

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Jul 24, 2023

What?

Backports changes from:

Why?

Keep things in sync

How?

Copy paste.

Testing Instructions

Tests should pass.

@ramonjd ramonjd added the Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core label Jul 24, 2023
@ramonjd ramonjd requested a review from getdave July 24, 2023 10:12
@ramonjd ramonjd self-assigned this Jul 24, 2023
@github-actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.3/navigation-fallback.php
❔ phpunit/class-gutenberg-rest-navigation-fallback-controller-test.php

@github-actions
Copy link

Flaky tests detected in 1993763.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5643583539
📝 Reported issues:

Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@ramonjd ramonjd merged commit e05e038 into trunk Jul 24, 2023
@ramonjd ramonjd deleted the update/backport-navigation-fallback-function-name branch July 24, 2023 23:50
@github-actions github-actions bot added this to the Gutenberg 16.4 milestone Jul 24, 2023
@mikachan mikachan added [Feature] Navigation Menus Any issue relating to Navigation Menus [Type] Bug An existing feature does not function as intended labels Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

⚠️ Type of PR label error

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Accessibility (a11y), [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: [Type] Bug, Backport from WordPress Core, [Feature] Navigation Menus.

You can learn more about the Type labels in Gutenberg here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] Navigation Menus Any issue relating to Navigation Menus [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants